feat(popup-menu): add API to provide custom no search results entry #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
Jan 17, 2024
nikku
reviewed
Jan 17, 2024
philippfromme
force-pushed
the
custom-no-search-results
branch
from
bc6d149 to
c00fcab
Compare
nikku
reviewed
Jan 17, 2024
philippfromme
force-pushed
the
custom-no-search-results
branch
2 times, most recently
from
45904e0 to
810f1bf
Compare
|
@nikku I adjusted the implementation as suggested. The search is now passed to the callback, which returns the custom node. |
philippfromme
force-pushed
the
custom-no-search-results
branch
9 times, most recently
from
c1f3aa9 to
8c33f15
Compare
|
🙃 How looks did out? Did you complete fine tuning this PR? |
philippfromme
force-pushed
the
custom-no-search-results
branch
2 times, most recently
from
c39750e to
baa7391
Compare
Unfortunately, I got stuck due to failing tests on Linux & Firefox. They are extremely flaky so I replaced |
bpmn-io-tasks
bot
added
in progress
philippfromme
force-pushed
the
custom-no-search-results
branch
4 times, most recently
from
47ae206 to
ce76967
Compare
bpmn-io-tasks
bot
added
needs review
|
@nikku Should be ready to be reviewed now. What a pain in the 🍑 that was. |
|
@philippfromme As discussed I went forth and do a little bit more work on this PR:
Please checkout what I did and see if it makes sense. |
nikku
reviewed
Jan 23, 2024
|
Looks good to me. @nikku I requested another review so feel free to approve and merge. |
Concatenating all searchable fields using `---` results in matching non-existing fields, e.g. `foo---bar`. test(popup-menu): add search test coverage
Ensures we call out what the things are, following our existing patterns of providers and consumers. BREAKING CHANGES: PopupMenu *Callback types renamed to *Provider.
nikku
force-pushed
the
custom-no-search-results
branch
from
4473f65 to
18c7bf2
Compare
nikku
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
getEmptyPlaceholderAPI toPopupMenuProviderto customize what's shown when there are no entries (after search). Based on the original issue is clear that a simple string or even an HTML string as it's used for icons (imgHtml) won't cut it here which means we have to allow users to return aVNode. The search is passed to the callback returning theVNodeso it can be taken into account.Example
Closes #846